Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked #87842

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

steffahn
Copy link
Member

@steffahn steffahn commented Aug 7, 2021

Recently, I edited the import list of the core::iter::traits::iterator module (in #85874). This results in a broken intra doc link in a hidden documentation with the effect that RUSTDOCFLAGS='--document-private-items --document-hidden-items' x doc library/std fails. (This can be worked around by adding -Arustdoc::broken-intra-doc-links; still, it’s a broken link so let’s fix it.)

@rustbot label C-cleanup, T-libs

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 7, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2021
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Aug 7, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2021

📌 Commit 5c30df5 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 7, 2021
…=dtolnay

Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked

Recently, I edited the import list of the `core::iter::traits::iterator` module (in rust-lang#85874). This results in a broken intra doc link in a hidden documentation with the effect that `RUSTDOCFLAGS='--document-private-items --document-hidden-items' x doc library/std` fails. (This can be worked around by adding `-Arustdoc::broken-intra-doc-links`; still, it’s a broken link so let’s fix it.)

`@rustbot` label C-cleanup, T-libs
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#87744 (Add x.py option to --force-rerun compiletest tests)
 - rust-lang#87789 (Make vec-shrink-panic test compatible with v0 mangling)
 - rust-lang#87833 (Fix typo -- "The" -> "They")
 - rust-lang#87834 (Fix small typo)
 - rust-lang#87838 (Document that fs::read_dir skips . and ..)
 - rust-lang#87842 (Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c159806 into rust-lang:master Aug 7, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 7, 2021
@steffahn steffahn deleted the hidden_broken_intra_doc branch August 7, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants