Take into account jobs number for rustdoc GUI tests #88082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
rustdoc-gui-jobs-opt
branch
from
cd0d229
to
9c21da6
Compare
dns2utf8
reviewed
Aug 16, 2021
| if (opts["jobs"] < 1) { | ||
| process.setMaxListeners(files.length + 1); | ||
| } else { | ||
| process.setMaxListeners(opts["jobs"]); |
There was a problem hiding this comment.
Will this give a warning to the users? If I remember correctly that warning was the reason why I increased the number to files.length + 1
There was a problem hiding this comment.
I didn't have any warning, so no idea. But we shouldn't go above the limit provided by the tester in any case.
There was a problem hiding this comment.
Cool
dns2utf8
approved these changes
Aug 16, 2021
|
@bors: r=dns2utf8 rollup |
|
📌 Commit 9c21da6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 19, 2021
…laumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#87818 (Fix anchors display in rustdoc) - rust-lang#87983 (Use more accurate spans when proposing adding lifetime to item) - rust-lang#88012 (Change WASI's `RawFd` from `u32` to `c_int` (`i32`).) - rust-lang#88031 (Make `BuildHasher` object safe) - rust-lang#88036 (Fix dead code warning when inline const is used in pattern) - rust-lang#88082 (Take into account jobs number for rustdoc GUI tests) - rust-lang#88109 (Fix environment variable getter docs) - rust-lang#88111 (Add background-color on clickable definitions in source code) - rust-lang#88129 (Fix dataflow graphviz bug, make dataflow graphviz modules public) - rust-lang#88136 (Move private_unused.rs test to impl-trait) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Aug 23, 2021
…-limit, r=dns2utf8 Greatly improve limitation handling on parallel rustdoc GUI test run Follow-up of rust-lang#88082. r? `@dns2utf8`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88054.
r? @Mark-Simulacrum