Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BuildHasher object safe #88031

Merged
merged 2 commits into from Aug 19, 2021
Merged

Make BuildHasher object safe #88031

merged 2 commits into from Aug 19, 2021

Conversation

ibraheemdev
Copy link
Member

Resolves #87991

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2021
@cuviper
Copy link
Member

cuviper commented Aug 16, 2021

I'm nominating this for backport since it's a beta regression and a simple fix.

@cuviper cuviper added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 16, 2021
@m-ou-se m-ou-se mentioned this pull request Aug 18, 2021
Closed
4 tasks
@m-ou-se m-ou-se assigned m-ou-se and unassigned joshtriplett Aug 18, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Aug 18, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 18, 2021

📌 Commit 58f988f has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 18, 2021
Merged
@m-ou-se m-ou-se added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 19, 2021
@bors
Auto merge of rust-lang#88143 - GuillaumeGomez:rollup-sgh318f, r=Guil…
ad1eaff 
…laumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#87818 (Fix anchors display in rustdoc)
 - rust-lang#87983 (Use more accurate spans when proposing adding lifetime to item)
 - rust-lang#88012 (Change WASI's `RawFd` from `u32` to `c_int` (`i32`).)
 - rust-lang#88031 (Make `BuildHasher` object safe)
 - rust-lang#88036 (Fix dead code warning when inline const is used in pattern)
 - rust-lang#88082 (Take into account jobs number for rustdoc GUI tests)
 - rust-lang#88109 (Fix environment variable getter docs)
 - rust-lang#88111 (Add background-color on clickable definitions in source code)
 - rust-lang#88129 (Fix dataflow graphviz bug, make dataflow graphviz modules public)
 - rust-lang#88136 (Move private_unused.rs test to impl-trait)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b7c771 into rust-lang:master Aug 19, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 19, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 27, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.56.0, 1.55.0 Aug 27, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2021
@bors
Auto merge of rust-lang#88400 - Mark-Simulacrum:beta-next, r=Mark-Sim…
27e88d3 
…ulacrum

[beta] backports

This PR rolls up a number of beta backports:

* Split critical edge targeting the start block rust-lang#88124
* Make BuildHasher object safe rust-lang#88031
* Fix Windows Command::env("PATH") rust-lang#87863
* Do not ICE on HIR based WF check when involving lifetimes rust-lang#87811
* Update compiler_builtins to fix i128 shift/mul on thumbv6m rust-lang#87633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@m-ou-se m-ou-se

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

BuildHasher is no longer object safe in 1.55
9 participants
@ibraheemdev @rust-highfive @cuviper @m-ou-se @bors @RalfJung @joshtriplett @Mark-Simulacrum @rustbot