Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #89037

Merged
merged 23 commits into from
Sep 17, 2021
Merged

Rollup of 10 pull requests #89037

merged 23 commits into from
Sep 17, 2021

Commits on Jul 31, 2021

  1. Configuration menu
    Copy the full SHA
    4e76c38 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Add TcpListener::into_incoming and IntoIncoming

    The `incoming` method is really useful, however for some use cases the borrow
    this introduces is needlessly restricting. Thus, an owned variant is added.
    piegamesde committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ced597e View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Doc comments

    bjorn3 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    a4a22f0 View commit details
    Browse the repository at this point in the history
  2. Move get_tools_search_paths from FileSearch to Session

    It only uses fields of FileSearch that are stored in Session too
    bjorn3 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    58000ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7ef0b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Configuration menu
    Copy the full SHA
    cbd7983 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Const Deref

    fee1-dead committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    349ac4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b0186e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. PassWrapper: handle separate Module*SanitizerPass

    Change ab41eef in LLVM split MemorySanitizerPass into
    MemorySanitizerPass for functions and ModuleMemorySanitizerPass for
    modules. There's a related change for ThreadSanitizerPass, and in here
    since we're using a ModulePassManager I only add the module flavor of
    the pass on LLVM 14.
    
    r? @nikic cc @nagisa
    durin42 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    a97f89a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc4d8af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f464bb View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Set the library path in sysroot-crates-are-unstable

    Most of the `run-make-fulldeps` tests use a make-driven rustc command
    that includes `HOST_RPATH_DIR` in the library path, but this particular
    test runs from python instead. When the toolchain is built without
    `rpath` enabled, we need that library path in the environment so it can
    find its own libraries.
    cuviper committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    67edf94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    378300a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#86382 - JohnTitor:try-desugar, r=estebank

    Make diagnostics clearer for `?` operators
    
    Re-submission of rust-lang#75029, fixes rust-lang#71309
    This also revives the `content` methods removed by rust-lang#83185.
    r? `@estebank`
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f4f7704 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#87529 - FabianWolff:issue-87496, r=nikomats…

    …akis
    
    Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types
    
    Fixes rust-lang#87496. There is also another function in the same file that looks fishy, but I haven't been able to produce an ICE there, and in any case, it's not related to rust-lang#87496:
    https://github.com/rust-lang/rust/blob/fd853c00e255559255885aadff9e93a1760c8728/compiler/rustc_lint/src/types.rs#L720-L734
    
    r? ```@JohnTitor```
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    81dc216 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#88339 - piegamesde:master, r=joshtriplett

    Add TcpListener::into_incoming and IntoIncoming
    
    The `incoming` method is really useful, however for some use cases the borrow
    this introduces is needlessly restricting. Thus, an owned variant is added.
    
    r? ``@joshtriplett``
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    0f06e36 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#88735 - hnj2:patch-1, r=GuillaumeGomez

    Don't lint about missing code examples in derived traits
    
    When the `missing_doc_code_examples` lint is performed it also requires that derived Trait implementations have a code example for each member etc., which causes undesirable behavior.
    
    # Examples
    
    With `missing_doc_code_examples` enable we are not able to use the `Clone` derive macro due to the generated code not being documented:
    ```rust
    #[deny(rustdoc::missing_doc_code_examples)]
    
    /// docs
    /// ```
    /// let s = SomeStruct;
    /// ```
    #[derive(Clone)]
    pub struct SomeStruct;
    ```
    yields:
    ```
     Documenting testt v0.1.0 (<redacted>)
    error: missing code example in this documentation
     --> src/lib.rs:7:10
      |
    7 | #[derive(Clone)]
      |          ^^^^^
      |
    note: the lint level is defined here
     --> src/lib.rs:1:8
      |
    1 | #[deny(rustdoc::missing_doc_code_examples)]
      |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    error: missing code example in this documentation
     --> src/lib.rs:7:10
      |
    7 | #[derive(Clone)]
      |          ^^^^^
    
    error: could not document `testt`
    
    Caused by:
      process didn't exit successfully: `rustdoc ...
    ```
    
    closes rust-lang#81775
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    758c7bc View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#88751 - bjorn3:move_filesearch, r=oli-obk

    Couple of changes to FileSearch and SearchPath
    
    * Turn a couple of regular comments into doc comments
    * Move `get_tools_search_paths` from `FileSearch` to `Session`
    * Use Lrc instead of Option to avoid duplication of a `SearchPath`
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    a84d39c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#88883 - c410-f3r:tests, r=petrochenkov

    Move some tests to more reasonable directories - 7
    
    cc rust-lang#73494
    r? ``@petrochenkov``
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5e91037 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#88887 - fee1-dead:const-deref, r=oli-obk

    Const Deref
    
    Implements `const Deref`/`const DerefMut` for `&mut T`, `&T`, `Cow<'_, B>` and `ManuallyDrop<T>`
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5d14396 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#88911 - FabianWolff:issue-88653, r=petroche…

    …nkov
    
    Improve error message for type mismatch in generator arguments
    
    Fixes rust-lang#88653. The code example given there is invalid because the `Generator` trait (unlike the `Fn` traits) does not take the generator arguments in tupled-up form (because there can only be one argument, from my understanding). Hence, the type error in the example in rust-lang#88653 is correct, because the given generator takes a `bool` argument, whereas the function's return type talks about a generator with a `(bool,)` argument.
    
    The error message is both confusing and wrong, though: It is wrong because it displays the wrong "expected signature", and it is confusing because both the "expected" and "found" notes point at the same span. With my changes, I get the following, more helpful output:
    ```
    error[E0631]: type mismatch in generator arguments
     --> test.rs:5:22
      |
    5 | fn foo(bar: bool) -> impl Generator<(bool,)> {
      |                      ^^^^^^^^^^^^^^^^^^^^^^^ expected signature of `fn((bool,)) -> _`
    6 |     |bar| {
      |     ----- found signature of `fn(bool) -> _`
    ```
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    c97ff09 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#89014 - durin42:llvm-14-module-pass-manager…

    …, r=nikic
    
    PassWrapper: handle separate Module*SanitizerPass
    
    Change ab41eef in LLVM split MemorySanitizerPass into
    MemorySanitizerPass for functions and ModuleMemorySanitizerPass for
    modules. There's a related change for ThreadSanitizerPass, and in here
    since we're using a ModulePassManager I only add the module flavor of
    the pass on LLVM 14.
    
    r? `@nikic` cc `@nagisa`
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3cff47b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#89033 - cuviper:sysroot-lib-path, r=Mark-Si…

    …mulacrum
    
    Set the library path in sysroot-crates-are-unstable
    
    Most of the `run-make-fulldeps` tests use a make-driven rustc command
    that includes `HOST_RPATH_DIR` in the library path, but this particular
    test runs from python instead. When the toolchain is built without
    `rpath` enabled, we need that library path in the environment so it can
    find its own libraries.
    JohnTitor committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    4d5bcbe View commit details
    Browse the repository at this point in the history