refactor: VecDeques IntoIter fields to private #89053
Conversation
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Hey, thank you for your quick feedback. My motivation behind this change and a few others I will be submitting, is I was told having fields of a struct accessible directly was a code smell. While no code is currently directly accessing the field this removes the possibility. |
|
@bors r+ rollup Alright, seems OK. I don't think this was necessarily a code smell or otherwise bad previously, since it was in practice just a crate-local field -- that's usually pretty harmless, especially when there's no invariants attached to the field (like here). But it is a little nicer if you can be confident that no other module is touching the field, so I'll approve this PR :) |
|
📌 Commit 05b01cd has been approved by |
bors
added
S-waiting-on-bors
…rivate, r=Mark-Simulacrum refactor: VecDeques IntoIter fields to private Made the fields of VecDeque's IntoIter private by creating a IntoIter::from(...) function to create a new instance of IntoIter and migrating usage to use IntoIter::from(...).
Rollup of 10 pull requests Successful merges: - rust-lang#87960 (Suggest replacing an inexisting field for an unmentioned field) - rust-lang#88855 (Allow simd_shuffle to accept vectors of any length) - rust-lang#88966 (Check for shadowing issues involving block labels) - rust-lang#88996 (Fix linting when trailing macro expands to a trailing semi) - rust-lang#89017 (fix potential race in AtomicU64 time monotonizer) - rust-lang#89021 (Add a separate error for `dyn Trait` in `const fn`) - rust-lang#89051 (Add intra-doc links and small changes to `std::os` to be more consistent) - rust-lang#89053 (refactor: VecDeques IntoIter fields to private) - rust-lang#89055 (Suggest better place to add call parentheses for method expressions wrapped in parentheses) - rust-lang#89081 (Fix a typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Made the fields of VecDeque's IntoIter private by creating a IntoIter::from(...) function to create a new instance of IntoIter and migrating usage to use IntoIter::from(...).