Add #[must_use] to alloc constructors #89726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-alloc-constructors
branch
from
26ee38e
to
58cc18c
Compare
|
I don't think any of these would make sense to call for a side effect. Theoretically they could have a side effect in the allocator, but I don't see any issue with requiring a @bors r+ |
|
📌 Commit ecd7ea8 has been approved by |
bors
added
S-waiting-on-bors
joshtriplett
added
the
relnotes
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2021
…rs, r=joshtriplett Add #[must_use] to alloc constructors Added `#[must_use]`. to the various forms of `new`, `pin`, and `with_capacity` in the `alloc` crate. No extra explanations given as I couldn't think of anything useful to add. I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular: * The 4 `pin`/`pin_in` methods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with. * `Box`'s constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory? Parent issue: rust-lang#89692 r? `@joshtriplett`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#89655 (bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts) - rust-lang#89726 (Add #[must_use] to alloc constructors) - rust-lang#89729 (Add #[must_use] to core and std constructors) - rust-lang#89743 (Fix RUSTC_LOG handling) - rust-lang#89753 (Add #[must_use] to from_value conversions) - rust-lang#89754 (Cleanup .item-table CSS) - rust-lang#89761 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
#[must_use]. to the various forms ofnew,pin, andwith_capacityin thealloccrate. No extra explanations given as I couldn't think of anything useful to add.I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular:
pin/pin_inmethods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with.Box's constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory?Parent issue: #89692
r? @joshtriplett