Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[must_use] to core and std constructors #89729

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

jkugelman
Copy link
Contributor

Parent issue: #89692

r? @joshtriplett

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2021
@jkugelman
Copy link
Contributor Author

jkugelman commented Oct 10, 2021

Heads up, I threw MaybeUninit into the mix. I'm not 100% sure if it belongs.

core::mem::MaybeUninit<T>   const fn uninit() -> MaybeUninit<T>;
core::mem::MaybeUninit<T>   const fn uninit_array<const LEN: usize>() -> [Self; LEN];
core::mem::MaybeUninit<T>   fn zeroed() -> MaybeUninit<T>;

I left MaybeUninit::new(val: T) out since it could be used to nullify T's drop code. Let me know if you think I should add it. I could put a note saying to use ManuallyDrop::new or mem::forget instead.

@joshtriplett
Copy link
Member

I do think it's reasonable to add the annotation to MaybeUninit::new as well, but that can happen in another PR. Suggesting mem::forget sounds good.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 11, 2021

📌 Commit 5b5c12b has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2021
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 11, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 11, 2021
…ctors, r=joshtriplett

Add #[must_use] to core and std constructors

Parent issue: rust-lang#89692

r? `@joshtriplett`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#89655 (bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts)
 - rust-lang#89726 (Add #[must_use] to alloc constructors)
 - rust-lang#89729 (Add #[must_use] to core and std constructors)
 - rust-lang#89743 (Fix RUSTC_LOG handling)
 - rust-lang#89753 (Add #[must_use] to from_value conversions)
 - rust-lang#89754 (Cleanup .item-table CSS)
 - rust-lang#89761 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77be7e4 into rust-lang:master Oct 11, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 11, 2021
@jkugelman jkugelman deleted the must-use-core-std-constructors branch October 11, 2021 17:55
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 11, 2021
…, r=joshtriplett

Add #[must_use] to MaybeUninit::new

As discussed in rust-lang#89729 (comment).

Parent issue: rust-lang#89692

r? `@joshtriplett`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2021
…, r=joshtriplett

Add #[must_use] to MaybeUninit::new

As discussed in rust-lang#89729 (comment).

Parent issue: rust-lang#89692

r? ``@joshtriplett``
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2021
…r=joshtriplett

Add #[must_use] to MaybeUninit::new

As discussed in rust-lang#89729 (comment).

Parent issue: rust-lang#89692

r? `@joshtriplett`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants