rustdoc: Use TTF based font instead of OTF for CJK glyphs to improve readability #90232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ghost
changed the title
ghost
changed the title
ghost
changed the title
This comment has been minimized.
This comment has been minimized.
ghost
changed the title
|
cc @jsha |
This comment has been minimized.
This comment has been minimized.
Can you include this part of your comment into the code as a comment so it's not forgotten please? Here would be perfect. |
|
Ah you also need to update a GUI test (since you updated the CSS). |
GuillaumeGomez
approved these changes
Oct 26, 2021
|
Thanks! @bors: r+ |
|
📌 Commit 9e00501 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 9e00501 with merge f3e5aa885b606f9c4ac1d8e71be5a32410ececc0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
It's probably a temporary error. Could someone run that test again? @bors: retry |
|
@ghost: 🔑 Insufficient privileges: not in try users |
|
The CI seems broken for now (a lot of other PRs are failing as well). Better wait when it's been fixed. |
|
@bors retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
rustdoc: Use TTF based font instead of OTF for CJK glyphs to improve readability Due to Windows' implementation of font rendering, OpenType fonts can be distorted. So the existing font, Noto Sans KR, is not very readable on Windows. This PR improves readability of Korean glyphs on Windows. ## Before  ## After  The fonts included in this PR are licensed under the SIL Open Font License and generated with these commands: ```sh pyftsubset NanumBarunGothic.ttf \ --unicodes=U+AC00-D7AF,U+1100-11FF,U+3130-318F,U+A960-A97F,U+D7B0-D7FF \ --output-file=NanumBarunGothic.ttf.woff --flavor=woff ``` ```sh pyftsubset NanumBarunGothic.ttf \ --unicodes=U+AC00-D7AF,U+1100-11FF,U+3130-318F,U+A960-A97F,U+D7B0-D7FF \ --output-file=NanumBarunGothic.ttf.woff2 --flavor=woff2 ``` r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90154 (rustdoc: Remove `GetDefId`) - rust-lang#90232 (rustdoc: Use TTF based font instead of OTF for CJK glyphs to improve readability) - rust-lang#90278 (rustdoc: use better highlighting for *const, *mut, and &mut) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Windows' implementation of font rendering, OpenType fonts can be distorted. So the existing font, Noto Sans KR, is not very readable on Windows. This PR improves readability of Korean glyphs on Windows.
Before
After
The fonts included in this PR are licensed under the SIL Open Font License and generated with these commands:
r? @GuillaumeGomez