Extend const_convert to rest of blanket core::convert impls #92382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
5 tasks
clarfonthey
force-pushed
the
const_convert
branch
from
27ca3cc
to
b1b873f
Compare
|
This seems reasonable, given than it's only available unstable. @bors r+ |
|
📌 Commit b1b873f has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
Extend const_convert to rest of blanket core::convert impls This adds constness to all the blanket impls in `core::convert` under the existing `const_convert` feature, tracked by rust-lang#88674. Existing impls under that feature: ```rust impl<T> const From<T> for T; impl<T, U> const Into<U> for T where U: ~const From<T>; impl<T> const ops::Try for Option<T>; impl<T> const ops::FromResidual for Option<T>; impl<T, E> const ops::Try for Result<T, E>; impl<T, E, F> const ops::FromResidual<Result<convert::Infallible, E>> for Result<T, F> where F: ~const From<E>; ``` Additional impls: ```rust impl<T: ?Sized, U: ?Sized> const AsRef<U> for &T where T: ~const AsRef<U>; impl<T: ?Sized, U: ?Sized> const AsRef<U> for &mut T where T: ~const AsRef<U>; impl<T: ?Sized, U: ?Sized> const AsMut<U> for &mut T where T: ~const AsMut<U>; impl<T, U> const TryInto<U> for T where U: ~const TryFrom<T>; impl<T, U> const TryFrom<U> for T where U: ~const Into<T>; ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92191 (Prefer projection candidates instead of param_env candidates for Sized predicates) - rust-lang#92382 (Extend const_convert to rest of blanket core::convert impls) - rust-lang#92625 (Add `#[track_caller]` to `mirbug`) - rust-lang#92684 (Export `tcp::IntoIncoming`) - rust-lang#92743 (Use pre-interned symbols in a couple of places) - rust-lang#92838 (Clean up some links in RELEASES) - rust-lang#92868 (librustdoc: Address some clippy lints) - rust-lang#92875 (Make `opt_const_param_of` work in the presence of `GenericArg::Infer`) - rust-lang#92891 (Add myself to .mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds constness to all the blanket impls in
core::convertunder the existingconst_convertfeature, tracked by #88674.Existing impls under that feature:
Additional impls: