Prefer projection candidates instead of param_env candidates for Sized predicates #92191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…didates instead of param_env candidates
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
Does this also solve #92798? |
nikomatsakis
approved these changes
Jan 14, 2022
|
I was a bit wary at first, but preferring a projection or dynamic candidate seems actually pretty harmless to me, and quite unlikely to influence inference, so +1. @bors r+ |
|
📌 Commit d3aecc1 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
Prefer projection candidates instead of param_env candidates for Sized predicates Fixes rust-lang#89352 Also includes some drive by logging and verbose printing changes that I found useful when debugging this, but I can remove this if needed. This is a little hacky - but imo no more than the rest of `candidate_should_be_dropped_in_favor_of`. Importantly, in a Chalk-like world, both candidates should be completely compatible. r? `@nikomatsakis`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
Prefer projection candidates instead of param_env candidates for Sized predicates Fixes rust-lang#89352 Also includes some drive by logging and verbose printing changes that I found useful when debugging this, but I can remove this if needed. This is a little hacky - but imo no more than the rest of `candidate_should_be_dropped_in_favor_of`. Importantly, in a Chalk-like world, both candidates should be completely compatible. r? ``@nikomatsakis``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92191 (Prefer projection candidates instead of param_env candidates for Sized predicates) - rust-lang#92382 (Extend const_convert to rest of blanket core::convert impls) - rust-lang#92625 (Add `#[track_caller]` to `mirbug`) - rust-lang#92684 (Export `tcp::IntoIncoming`) - rust-lang#92743 (Use pre-interned symbols in a couple of places) - rust-lang#92838 (Clean up some links in RELEASES) - rust-lang#92868 (librustdoc: Address some clippy lints) - rust-lang#92875 (Make `opt_const_param_of` work in the presence of `GenericArg::Infer`) - rust-lang#92891 (Add myself to .mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
May 1, 2022
…env candidates for Sized predicates
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
May 4, 2022
…env candidates for Sized predicates
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 13, 2022
…env candidates for Sized predicates
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
May 17, 2022
…env candidates for Sized predicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89352
Also includes some drive by logging and verbose printing changes that I found useful when debugging this, but I can remove this if needed.
This is a little hacky - but imo no more than the rest of
candidate_should_be_dropped_in_favor_of. Importantly, in a Chalk-like world, both candidates should be completely compatible.r? @nikomatsakis