Do not use deprecated -Zsymbol-mangling-version in bootstrap #92516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Passing -Zunstable-options should be fine for stage 1+ in the case we need to set legacy. Please also add a |
Mark-Simulacrum
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
bootstrap-symbol-mangling
branch
from
b190b3b
to
f6eeaf1
Compare
Mark-Simulacrum
force-pushed
the
bootstrap-symbol-mangling
branch
from
f6eeaf1
to
e266cb9
Compare
|
Oh, I see that you already took care of it 😅 Thanks! |
|
@bors r+ rollup |
|
📌 Commit e266cb9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91587 (core::ops::unsize: improve docs for DispatchFromDyn) - rust-lang#91907 (Allow `_` as the length of array types and repeat expressions) - rust-lang#92515 (RustWrapper: adapt for an LLVM API change) - rust-lang#92516 (Do not use deprecated -Zsymbol-mangling-version in bootstrap) - rust-lang#92530 (Move `contains` method of Option and Result lower in docs) - rust-lang#92546 (Update books) - rust-lang#92551 (rename StackPopClean::None to Root) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Zsymbol-mangling-versionnow produces warnings unconditionally. So if you want to use legacy mangling for the compiler (new-symbol-mangling = falseinconfig.toml), the build is now littered with warnings.However, with this change, stage 1
stddoesn't compile:Even after the bootstrap compiler is updated and it will support
-Csymbol-mangling-version, the bootstrap code would either need to use-Zfor the legacy mangling or use-Cin combination with-Z unstable-options(because-C+ legacy is not allowed without the unstable options). Should we just add-Z unstable-optionstostdcompilation to resolve this?Btw I use legacy mangling because the new mangling is not supported by Hotspot.