Update theme on pageshow event #93253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user goes forward or back, the page may be rendered from the back/forward cache (https://web.dev/bfcache/) rather than from scratch. If they have changed theme in the meantime, that means seeing an incorrect theme on the page they went forward or back to. The `pageshow` event fires on such navigations, so we can update the theme based on that event.
rustbot
added
the
T-rustdoc
|
Quite the tricky case, good catch! I now see why you opened GuillaumeGomez/browser-UI-test#245. I'll open an issue so we don't forget to add a test. Thanks! @bors: r+ rollup |
|
📌 Commit b30725e has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf) - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)) - rust-lang#93186 (Fix link to CVE-2022-21658) - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar) - rust-lang#93231 (adjust sidebar link brightness) - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar) - rust-lang#93253 (Update theme on pageshow event) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user goes forward or back, the page may be rendered from the back/forward cache (https://web.dev/bfcache/) rather than from scratch. If they have changed theme in the meantime, that means seeing an incorrect theme on the page they went forward or back to. The
pageshowevent fires on such navigations, so we can update the theme based on that event.Demo: https://rustdoc.crud.net/jsha/theme-on-show/std/string/trait.ToString.html
r? @GuillaumeGomez