-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] CI time regression fixing experiments #94195
Conversation
@bors try |
⌛ Trying commit 320e4ee97d6c113271e14bc287d4059344749769 with merge 77ce11ad013449792a9a332263ca389013416974... |
This comment has been minimized.
This comment has been minimized.
320e4ee
to
dea6912
Compare
@bors try |
⌛ Trying commit dea69120f27c51759253070f7f646ca22da06521 with merge 8814424d8d7e891672ab1372150e9e3dff044c8d... |
☀️ Try build successful - checks-actions |
dea6912
to
f2a1b81
Compare
Results look back to expected timing -- dropped the revert to confirm, and if so we'll likely want to revert that PR for now until we have an answer for why it makes CI so much slower. |
@bors try |
⌛ Trying commit f2a1b8160e3c7a6e635164969f221eb12526a13f with merge 5774537111fdb664facc04c632ba46ea61dd9778... |
☀️ Try build successful - checks-actions |
Closing -- posted a revert in #94205 |
…r=oli-obk Treat static refs as `mir::ConstantKind::Val` With the upcoming introduction of Valtrees we want to treat more values as `mir::ConstantKind::Val` directly. r? `@lcnr` cc `@oli-obk`
f2a1b81
to
6452d85
Compare
⌛ Trying commit 6452d85 with merge 60c31889727268c87c952b365b81916c4803602a... |
☀️ Try build successful - checks-actions |
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/msvc.28.3F.29.20builders.20running.20much.20slower
It looks like #93800 was most recently responsible for a large regression in parallelism on the msvc-alt dist builder, so let's try reverting it and seeing if that helps. (The alternative is that something somehow changed in the environment, but only seems to affect rustc builds, not std).
r? @Mark-Simulacrum