Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] CI time regression fixing experiments #94195

Closed
wants to merge 2 commits into from

Conversation

Mark-Simulacrum
Copy link
Member

https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/msvc.28.3F.29.20builders.20running.20much.20slower

It looks like #93800 was most recently responsible for a large regression in parallelism on the msvc-alt dist builder, so let's try reverting it and seeing if that helps. (The alternative is that something somehow changed in the environment, but only seems to affect rustc builds, not std).

r? @Mark-Simulacrum

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 20, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 20, 2022

⌛ Trying commit 320e4ee97d6c113271e14bc287d4059344749769 with merge 77ce11ad013449792a9a332263ca389013416974...

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 20, 2022

⌛ Trying commit dea69120f27c51759253070f7f646ca22da06521 with merge 8814424d8d7e891672ab1372150e9e3dff044c8d...

@bors
Copy link
Contributor

bors commented Feb 20, 2022

☀️ Try build successful - checks-actions
Build commit: 8814424d8d7e891672ab1372150e9e3dff044c8d (8814424d8d7e891672ab1372150e9e3dff044c8d)

@Mark-Simulacrum
Copy link
Member Author

Results look back to expected timing -- dropped the revert to confirm, and if so we'll likely want to revert that PR for now until we have an answer for why it makes CI so much slower.

@Mark-Simulacrum
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 20, 2022

⌛ Trying commit f2a1b8160e3c7a6e635164969f221eb12526a13f with merge 5774537111fdb664facc04c632ba46ea61dd9778...

@bors
Copy link
Contributor

bors commented Feb 21, 2022

☀️ Try build successful - checks-actions
Build commit: 5774537111fdb664facc04c632ba46ea61dd9778 (5774537111fdb664facc04c632ba46ea61dd9778)

@Mark-Simulacrum
Copy link
Member Author

Closing -- posted a revert in #94205

Mark-Simulacrum and others added 2 commits February 25, 2022 15:24
…r=oli-obk

Treat static refs as `mir::ConstantKind::Val`

With the upcoming introduction of Valtrees we want to treat more values as `mir::ConstantKind::Val` directly.

r? `@lcnr`

cc `@oli-obk`
@Mark-Simulacrum
Copy link
Member Author

@bors try

Checking whether re-landing #93800 on latest master still reproduces the regression.

@bors
Copy link
Contributor

bors commented Feb 25, 2022

⌛ Trying commit 6452d85 with merge 60c31889727268c87c952b365b81916c4803602a...

@bors
Copy link
Contributor

bors commented Feb 25, 2022

☀️ Try build successful - checks-actions
Build commit: 60c31889727268c87c952b365b81916c4803602a (60c31889727268c87c952b365b81916c4803602a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants