Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc-json: Clean Up json format #94921

Merged
merged 2 commits into from
Mar 14, 2022
Merged

rustdoc-json: Clean Up json format #94921

merged 2 commits into from
Mar 14, 2022

Conversation

aDotInTheVoid
Copy link
Member

No semantic changes, but better names

Closes #94198

Closes #94889

r? @CraftSpider

@rustbot modify labels: +A-rustdoc-json +T-rustdoc +C-cleanup

@rust-highfive
Copy link
Collaborator

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider,@aDotInTheVoid

@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Mar 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2022
@CraftSpider
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2022

📌 Commit a5c0b14 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2022
@bors
Copy link
Contributor

bors commented Mar 14, 2022

⌛ Testing commit a5c0b14 with merge 6b9b2bd...

@bors
Copy link
Contributor

bors commented Mar 14, 2022

☀️ Test successful - checks-actions
Approved by: CraftSpider
Pushing 6b9b2bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2022
@bors bors merged commit 6b9b2bd into rust-lang:master Mar 14, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6b9b2bd): comparison url.

Summary: This benchmark run did not return any relevant results. 8 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Enselic Enselic mentioned this pull request Mar 15, 2022
Closed
@aDotInTheVoid aDotInTheVoid mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CraftSpider CraftSpider

Labels
A-rustdoc-json Area: Rustdoc JSON backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

rustdoc-json-types: Inconsistant spelling of type/ty rustdoc-json: Rename implementors to implementations
6 participants
@aDotInTheVoid @rust-highfive @CraftSpider @bors @rust-timer @rustbot