Include a header in .rlink files #95589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a wrong file is parsed as .rlink
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @bjorn3 |
bjorn3
reviewed
Apr 2, 2022
bjorn3
reviewed
Apr 2, 2022
You can use something like |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
|
📌 Commit b81d873 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95587 (Remove need for associated_type_bounds in std.) - rust-lang#95589 (Include a header in .rlink files) - rust-lang#95593 (diagnostics: add test case for bogus T:Sized suggestion) - rust-lang#95597 (Refer to u8 by absolute path in expansion of thread_local) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find the right place where to put tests. Is there some location that tests
.rlinkcreation and loading?I only found
src/test/run-make-fulldeps/separate-link/Makefile, but I'm not sure how to check the error message in the Makefile.Fixes: #95297
r? @bjorn3