Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message in case of missing checksum #95885

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Improve error message in case of missing checksum #95885

merged 1 commit into from
Apr 13, 2022

Conversation

gimbling-away
Copy link
Contributor

Fixes

#94217

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

Looks like a few remaining tidy errors. Once those are fixed, and commits squashed, happy to merge this -- thank you!

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gimbling-away
Copy link
Contributor Author

Looks like a few remaining tidy errors. Once those are fixed, and commits squashed, happy to merge this -- thank you!

Oh yeah, my bad I was gone for school stuff the day. Completely forgot about this.

I'll get back this tomorrow? well I hope at least :P

@Dylan-DPC
Copy link
Member

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2022

📌 Commit b63d5f469d538e589ac6b9ffe4185052aa531b34 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2022
@Mark-Simulacrum
Copy link
Member

@bors r-

Please do squash commits. Thanks!

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2022
@gimbling-away
Copy link
Contributor Author

Squashed commits @Mark-Simulacrum 🎉

@Dylan-DPC
Copy link
Member

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2022

📌 Commit 71ad003 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2022
@bors
Auto merge of rust-lang#96015 - Dylan-DPC:rollup-vhdprid, r=Dylan-DPC
0d13f6a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#93217 (Improve Rustdoc UI for scraped examples with multiline arguments, fix overflow in line numbers)
 - rust-lang#95885 (Improve error message in case of missing checksum)
 - rust-lang#95962 (Document that DirEntry holds the directory open)
 - rust-lang#95991 (fix: wrong trait import suggestion for T:)
 - rust-lang#96005 (Add missing article to fix "few" to "a few".)
 - rust-lang#96006 (Add a missing article)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d449a63 into rust-lang:master Apr 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gimbling-away @rust-highfive @rust-log-analyzer @Mark-Simulacrum @Dylan-DPC @bors @rustbot