Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid nested opaque types to reference HRTB from opaque types. #97039

Merged
merged 2 commits into from
May 14, 2022

Conversation

cjgillot
Copy link
Contributor

Avoids #96194
Alternative to #96970

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2022
@aliemjay
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented May 14, 2022

@aliemjay: 🔑 Insufficient privileges: not in try users

@cjgillot
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented May 14, 2022

⌛ Trying commit b276b65 with merge 964cb6ab31b62c60eb4b2fdc021a166f0b6076d4...

@jackh726
Copy link
Member

This seems much nicer than #96970.

Crater run for this can happen in parallel, but let's get this in for the release train.

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 14, 2022

📌 Commit 872f09c has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2022
@bors
Copy link
Contributor

bors commented May 14, 2022

⌛ Testing commit 872f09c with merge b36be12...

@bors
Copy link
Contributor

bors commented May 14, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing b36be12 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
Forbid nested opaque types to reference HRTB from opaque types.

Backport version of rust-lang#97039 if useful.

r? `@Mark-Simulacrum`
@bors bors merged commit b36be12 into rust-lang:master May 14, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b36be12): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Mark-Simulacrum
Copy link
Member

Backported to beta via #97040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants