-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change remap
from FxHashSet
to IndexVec
in StateTransform
mir-opt
#97132
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 1fb5bdc with merge b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a... |
☀️ Try build successful - checks-actions |
Queued b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a with parent d8a3fc4, future comparison URL. |
Finished benchmarking commit (b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never |
It doesn't look like this change will improve performance. Thanks for helping with perf testing, I think this PR can be closed. |
This PR fixes the FIXME in the
StateTransform
mir-opt which change theremap
field inTransformVisitor
fromFxHashSet
toIndexVec
.This should save a little time for mir-opt, with relatively a little more memory using