Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change remap from FxHashSet to IndexVec in StateTransform mir-opt #97132

Closed
wants to merge 1 commit into from

Conversation

SparrowLii
Copy link
Member

@SparrowLii SparrowLii commented May 18, 2022

This PR fixes the FIXME in the StateTransform mir-opt which change the remap field in TransformVisitor from FxHashSet to IndexVec.
This should save a little time for mir-opt, with relatively a little more memory using

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 18, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@wesleywiser
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 19, 2022
@bors
Copy link
Contributor

bors commented May 19, 2022

⌛ Trying commit 1fb5bdc with merge b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a...

@bors
Copy link
Contributor

bors commented May 19, 2022

☀️ Try build successful - checks-actions
Build commit: b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a (b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a)

@rust-timer
Copy link
Collaborator

Queued b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a with parent d8a3fc4, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b474b80eaecf39f4c8cd8d09b8e43618c59c5d5a): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 19, 2022
@SparrowLii
Copy link
Member Author

It doesn't look like this change will improve performance. Thanks for helping with perf testing, I think this PR can be closed.

@SparrowLii SparrowLii closed this May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants