Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve u32 as char cast diagnostic #97169

Merged
merged 1 commit into from
May 20, 2022
Merged

Improve u32 as char cast diagnostic #97169

merged 1 commit into from
May 20, 2022

Conversation

gimbling-away
Copy link
Contributor

Fixes #97160

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 19, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2022
@gimbling-away gimbling-away mentioned this pull request May 19, 2022
Closed
@gimbling-away gimbling-away marked this pull request as draft May 19, 2022 07:59
@gimbling-away
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov marked this pull request as ready for review May 19, 2022 12:22
@petrochenkov
Copy link
Contributor

r=me after squashing commits.

@gimbling-away
Copy link
Contributor Author

@petrochenkov Squashed 👏🏻

@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented May 19, 2022

📌 Commit 9e5c24e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request May 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2022
@bors
Auto merge of rust-lang#97180 - Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96539 (Add release notes for 1.61.0)
 - rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
 - rust-lang#97155 (Fix doc typo)
 - rust-lang#97169 (Improve `u32 as char` cast diagnostic)
 - rust-lang#97170 (Remove unnecessay .report() on ExitCode)
 - rust-lang#97171 (Add regression test for rust-lang#88119)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3913d99 into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
@gimbling-away gimbling-away deleted the u32-diagnostic branch May 20, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

u32 as char: suggested code is unchanged
6 participants
@gimbling-away @rust-highfive @rust-log-analyzer @petrochenkov @bors @rustbot