Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #97662

Closed
wants to merge 13 commits into from

Commits on Apr 23, 2022

  1. Configuration menu
    Copy the full SHA
    47030d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Configuration menu
    Copy the full SHA
    267a6c8 View commit details
    Browse the repository at this point in the history
  2. update explicit impls error msg

    lcnr committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    79c3011 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Configuration menu
    Copy the full SHA
    d7645f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2898890 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e2ac5d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9292c90 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#95833 - notriddle:notriddle/human-readable-…

    …signals, r=yaahc
    
    std: `<ExitStatus as Display>::fmt` name the signal it died from
    
    Related to rust-lang#95601
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    daa6b17 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#97502 - onlineSoftwareDevOK:rustdocTests, r…

    …=GuillaumeGomez
    
    rustdoc: Add more test coverage
    
    Related issue rust-lang#91113
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    7aebfa5 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97627 - lcnr:comment-tick, r=Dylan-DPC

    update explicit impls error msg
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    bae8a57 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#97640 - TaKO8Ki:fix-wrong-suggestion-for-ad…

    …ding-where-clauses, r=lcnr
    
    Fix wrong suggestion for adding where clauses
    
    closes rust-lang#97576
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    2058c37 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#97645 - lcnr:derived-impl-debug, r=cjgillot

    don't use a `span_note` for ignored impls
    
    Searching for the `derive` isn't too difficult as it's right above the field definition.
    
    By using a span these errors are a lot more verbose than they should be, which is especially annoying as one can end up with a lot of `dead_code` warnings.
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    26425b6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#97655 - steffahn:better-pin-box-constructio…

    …n-docs, r=thomcc
    
    Improve documentation for constructors of pinned `Box`es
    
    Adds a cross-references between `Box::pin` and `Box::into_pin` (and other related methods, i.e. the equivalent `From` implementation, and the unstable `pin_in` method), in particular now that `into_pin` [was stabilized](rust-lang#97397). The main goal is to further improve visibility of the fact that `Box<T> -> Pin<Box<T>>` conversion exits in the first place, and that `Box::pin(x)` is – essentially – just a convenience function for `Box::into_pin(Box::new(x))`
    
    The motivating context why I think this is important is even experienced Rust users overlooking the existence this kind of conversion, [e.g. in this thread on IRLO](https://internals.rust-lang.org/t/pre-rfc-function-variants/16732/7?u=steffahn); and also the fact that that discussion brought up that there would be a bunch of Box-construction methods "missing" such as e.g. methods with fallible allocation a la "`Box::try_pin`", and similar; while those are in fact *not* necessary, because you can use `Box::into_pin(Box::try_new(x)?)` instead.
    
    I have *not* included explicit mention of methods (e.g. `try_new`) in the docs of stable methods (e.g. `into_pin`). (Referring to unstable API in stable API docs would be bad style IMO.) Stable examples I have in mind with the statement "constructing a (pinned) Box in a different way than with `Box::new`" are things like cloning a `Box`, or `Box::from_raw`. If/when `try_new` would get stabilized, it would become a very good concrete example use-case of `Box::into_pin` IMO.
    matthiaskrgr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    3a68052 View commit details
    Browse the repository at this point in the history