-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: <ExitStatus as Display>::fmt
name the signal it died from
#95833
std: <ExitStatus as Display>::fmt
name the signal it died from
#95833
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
FWIW I actually have written code to do this myself and think it might be a lot more comfortable to directly use the constants from For example, defining a |
I would love to use the functions from libc, but all the ones I could find were thread-unsafe. |
To clarify, I don't mean using the functions from libc, but rather using the definitions of the constants for each of the signals, like |
935050d
to
e985ed0
Compare
You're right. I didn't even think of that. That's much simpler. |
e985ed0
to
47030d3
Compare
Let's ping the libs team for the approval. cc @rust-lang/libs |
Looks great, ty! @bors r+ |
📌 Commit 267a6c8 has been approved by |
…signals, r=yaahc std: `<ExitStatus as Display>::fmt` name the signal it died from Related to rust-lang#95601
@bors r- failed in a rollup: #97662 (comment) |
c8d8e20
to
b767887
Compare
b767887
to
22791bb
Compare
Sorry, @yaahc. I've added another commit to address the MIPS trouble. |
@bors r+ rollup=never |
📌 Commit 22791bb has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a6b8c69): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Related to #95601