Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICEs from zsts within unsized types with non-zero offsets #97738

Merged
merged 3 commits into from Jun 7, 2022
Merged

Fix ICEs from zsts within unsized types with non-zero offsets #97738

merged 3 commits into from Jun 7, 2022

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jun 4, 2022

r? @eddyb

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 4, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2022
@Kixiron
Copy link
Member Author

Kixiron commented Jun 4, 2022

@rustbot label +I-ICE +T-compiler

@rustbot rustbot added the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Jun 4, 2022
eddyb
eddyb requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the test expanded to actually call the problem function.

src/test/ui/unsized/issue-97732.rs Outdated Show resolved Hide resolved
@Kixiron @eddyb
Update src/test/ui/unsized/issue-97732.rs
10336cf 
Co-authored-by: Eduard-Mihai Burtescu <edy.burt@gmail.com>
@Kixiron Kixiron requested a review from eddyb June 6, 2022 15:40
@eddyb
Copy link
Member

eddyb commented Jun 6, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2022

📌 Commit 10336cf has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 7, 2022
@Dylan-DPC
Rollup merge of rust-lang#97738 - Kixiron:zst-panic, r=eddyb
0ffca47 
Fix ICEs from zsts within unsized types with non-zero offsets

- Fixes rust-lang#97732
- Fixes ICEs while compiling `alloc` with `-Z randomize-layout`

r? `@eddyb`
This was referenced Jun 7, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2022
@bors
Auto merge of rust-lang#97825 - Dylan-DPC:rollup-ya51k1k, r=Dylan-DPC
7fe2c4b 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97058 (Various refactors to the incr comp workproduct handling)
 - rust-lang#97301 (Allow unstable items to be re-exported unstably without requiring the feature be enabled)
 - rust-lang#97738 (Fix ICEs from zsts within unsized types with non-zero offsets)
 - rust-lang#97771 (Remove SIGIO reference on Haiku)
 - rust-lang#97808 (Add some unstable target features for the wasm target codegen)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62c260d into rust-lang:master Jun 7, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 7, 2022
@Kixiron Kixiron deleted the zst-panic branch June 7, 2022 14:49
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jul 26, 2022
@bors
Auto merge of rust-lang#97825 - Dylan-DPC:rollup-ya51k1k, r=Dylan-DPC
b867d41 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97058 (Various refactors to the incr comp workproduct handling)
 - rust-lang#97301 (Allow unstable items to be re-exported unstably without requiring the feature be enabled)
 - rust-lang#97738 (Fix ICEs from zsts within unsized types with non-zero offsets)
 - rust-lang#97771 (Remove SIGIO reference on Haiku)
 - rust-lang#97808 (Add some unstable target features for the wasm target codegen)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

ICE from ZSTs not at the start of structs during codegen for unsizing coercions
5 participants
@Kixiron @eddyb @bors @rust-highfive @rustbot