Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_target: Add convenience functions for adding linker arguments #98212

Merged
merged 2 commits into from
Jun 27, 2022
Merged

rustc_target: Add convenience functions for adding linker arguments #98212

merged 2 commits into from
Jun 27, 2022

Conversation

petrochenkov
Copy link
Contributor

They ensure that lld and non-lld linker flavors get the same set of arguments.

The second commit also adds some tests checking for linker argument inconsistencies, and tweaks some arguments to fix those inconsistencies.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 17, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2022
@petrochenkov
Copy link
Contributor Author

r? @lqd

@rust-highfive rust-highfive assigned lqd and unassigned estebank Jun 17, 2022
@bors

This comment was marked as resolved.

Sign in to view
lqd
lqd reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, cleaner and more efficient.

I left a couple questions, and apart from the pre-link args in wasm32-unknown-emscripten , r=me after rebase.

compiler/rustc_target/src/spec/wasm32_unknown_emscripten.rs Outdated Show resolved Hide resolved
compiler/rustc_target/src/spec/wasm32_unknown_emscripten.rs Show resolved Hide resolved
compiler/rustc_target/src/spec/x86_64_pc_windows_gnu.rs Show resolved Hide resolved
@lqd
Copy link
Member

lqd commented Jun 22, 2022

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
@petrochenkov
Copy link
Contributor Author

Updated.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2022
@lqd
Copy link
Member

lqd commented Jun 22, 2022

@bors r+ rollup=never

(so that it's easy to bisect in case we missed something)

@bors
Copy link
Contributor

bors commented Jun 22, 2022

📌 Commit f9e5d3b0327f8c71cbcb2634637b2bae0420595f has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
@bors
Copy link
Contributor

bors commented Jun 22, 2022

⌛ Testing commit f9e5d3b0327f8c71cbcb2634637b2bae0420595f with merge a0fc6e6516067988f123936386264e7a9b654e11...

@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2022
@lqd
Copy link
Member

lqd commented Jun 22, 2022

GH network issues
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@petrochenkov
Copy link
Contributor Author

@bors r=lqd

@bors
Copy link
Contributor

bors commented Jun 24, 2022

📌 Commit ad2c36197a5c24e8398f097b1d9dcd19e27fe6a7 has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2022
@petrochenkov
Copy link
Contributor Author

@bors r=lqd

@bors
Copy link
Contributor

bors commented Jun 24, 2022

📌 Commit 8a9bef063ddd4c0b68c94a7f489310433e35c9aa has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2022
@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2022
@petrochenkov
Copy link
Contributor Author

@bors r=lqd

@bors
Copy link
Contributor

bors commented Jun 25, 2022

📌 Commit 456f65e has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2022
@bors
Copy link
Contributor

bors commented Jun 27, 2022

⌛ Testing commit 456f65e with merge 221bdb6...

@bors
Copy link
Contributor

bors commented Jun 27, 2022

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 221bdb6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2022
@bors bors merged commit 221bdb6 into rust-lang:master Jun 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 27, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (221bdb6): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.7% -3.8% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 8.0% 8.0% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.1% -3.9% 2
All 😿🎉 (primary) 8.0% 8.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@marysaka marysaka mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd left review comments

Assignees

@lqd lqd

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @bors @lqd @rust-log-analyzer @rust-timer @estebank @rustbot