Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r… #99495

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r… #99495

merged 1 commit into from
Jul 20, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 20, 2022

…=estebank"

This reverts commit 6f8fb91, reversing
changes made to 7210e46.

r? @ghost

rebase of #99368

@oli-obk
Revert "Rollup merge of rust-lang#98582 - oli-obk:unconstrained_opaqu…
4a742a6 
…e_type, r=estebank"

This reverts commit 6f8fb91, reversing
changes made to 7210e46.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 20, 2022

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 20, 2022

📌 Commit 4a742a6 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 20, 2022
@bors
Copy link
Contributor

bors commented Jul 20, 2022

⌛ Testing commit 4a742a6 with merge d60d88f...

@bors
Copy link
Contributor

bors commented Jul 20, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d60d88f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2022
@bors bors merged commit d60d88f into rust-lang:master Jul 20, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 20, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d60d88f): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.6% -2.6% 136
Improvements 🎉
(secondary)		 -1.0% -5.5% 93
All 😿🎉 (primary) -0.6% -2.6% 136

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 5.1% 5.1% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -4.0% -4.0% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -3.2% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.2% -3.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Jul 21, 2022
Closed
@aliemjay aliemjay mentioned this pull request Jul 23, 2022
Closed
@cr1901 cr1901 mentioned this pull request Jul 24, 2022
Closed
@oli-obk oli-obk deleted the revert_98582 branch July 27, 2022 08:53
celinval added a commit to celinval/kani-dev that referenced this pull request Aug 8, 2022
@celinval
Fix compilation errors
81a692c 
Regression is still failing. Related changes:

- rust-lang/rust#99420
- rust-lang/rust#99495
- rust-lang/rust#99844
- rust-lang/rust#99058
celinval added a commit to celinval/kani-dev that referenced this pull request Aug 15, 2022
@celinval
Fix compilation errors
45887b5 
Regression is still failing. Related changes:

- rust-lang/rust#99420
- rust-lang/rust#99495
- rust-lang/rust#99844
- rust-lang/rust#99058
@celinval celinval mentioned this pull request Aug 15, 2022
Merged
4 tasks
celinval added a commit to model-checking/kani that referenced this pull request Aug 17, 2022
@celinval @danielsn
Late toolchain upgrade to use nightly-2022-08-02 (#1522)
632fda6 
* Fix compilation errors

Regression is still failing. Related changes:

- rust-lang/rust#99420
- rust-lang/rust#99495
- rust-lang/rust#99844
- rust-lang/rust#99058

* Change test to expect compilation failure

The compiler has reverted their fix to Opaque types due to performance
degradation.

* Fix VTable handling now that it has an Opaque type

 - Add an implementation for vtable_size and vtable_align intrinsics.
 - Change how we handled Foreign types. Even though they are unsized, a
   pointer to foreign types is a thin pointer.

Co-authored-by: Daniel Schwartz-Narbonne <danielsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oli-obk @rustbot @bors @rust-timer