Improve documentation of MIR queries & passes #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
waiting-on-review
tshepang
reviewed
Aug 22, 2022
accidently -> accidentally Co-authored-by: Tshepang Mbambo <tshepang@gmail.com>
|
with rust-lang/rust#99102 now accepted, does this need to change |
JohnTitor
added
waiting-on-review
|
Yes, the doc in this PR need to change to reflect the recent changes in rust-lang/rust#99102. But we could wait a minute until it gets more stable and complete since the MIR phases and semantics there, I think, are under overhaul. |
JohnTitor
added
blocked
|
rust-lang/rust#99102 has been merged :) |
JohnTitor
added
the
waiting-on-review
oli-obk
requested changes
Feb 9, 2023
| the final, optimized MIR. For foreign def-ids, we simply read the MIR | ||
| If you would like to get the MIR: | ||
|
|
||
| - for a function - you can use the `optimized_mir(def_id)` query; |
There was a problem hiding this comment.
there's also the MIR that const eval sees for a function: mir_for_ctfe(def_id)
|
cc @JakobDegen |
spastorino
added
waiting-on-author
|
I'm not sure what's the current status of this PR, but would be great if we merge something about it, thoughts?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve the documentation of MIR queries and passes.
Below is the summary of changes:
mir_validatedmir_promotedandmir_drops_elaborated_and_const_checkedNoLandingPadspass example withCleanupNonCodegenStatementsmdbook-mermaidin the build instructionsFIXME:
ty::queries::foo::force(...)still appear in rustc?Since rust-lang/rust#99102 may significantly change the MIR queries (and thus its doc), we can wait for its result or send follow-up PRs. This is mostly documenting the code in
rustc_mir_transform, so maybe cc @rust-lang/wg-mir-opt.