Resync config.toml and suggest better settings #795
Conversation
src/building/how-to-build-and-run.md
Outdated
| # Emits extraneous output from tests to ensure that failures of the test | ||
| # harness are debuggable just from logfiles. | ||
| verbose-tests = true |
There was a problem hiding this comment.
| # Emits extraneous output from tests to ensure that failures of the test | |
| # harness are debuggable just from logfiles. | |
| verbose-tests = true | |
| # Emits extra output from tests so test failures are debuggable just from logfiles. | |
| verbose-tests = true |
Extraneous means it's not useful or irrelevant.
There was a problem hiding this comment.
@jyn514 👍 but consider changing this on rust-lang/rust, I've just copied what it's there already.
There was a problem hiding this comment.
This change doesn't seem right, specifically "test harness" refers to the code running the tests, rather than the tests themselves. And it is extraneous for the common case of e.g. libtest not crashing.
EDIT: found the Rust PR, leaving comment there too.
spastorino
force-pushed
the
config-toml-suggestions
branch
from
39e14f4
to
818d97d
Compare
spastorino
force-pushed
the
config-toml-suggestions
branch
from
818d97d
to
d4f978d
Compare
bootstrap: Improve wording on docs for `verbose-tests` From rust-lang/rustc-dev-guide#795 (comment) r? @spastorino
| # This will make your build more parallel; it costs a bit of runtime | ||
| # performance perhaps (less inlining) but it's worth it. |
There was a problem hiding this comment.
Was this from config.toml.example? It looks like these two lines explained why the = 0 value was set, and this was lost.
There was a problem hiding this comment.
Yes, this is from config.toml.example. I'll add it back in rust-lang/rust#76141.
| # Emits extra output from tests so test failures are debuggable just from logfiles. | ||
| verbose-tests = true |
There was a problem hiding this comment.
Why was this added? The default is that failures are listed at the end, without noisy output while running the tests.
EDIT: looks like the purpose of this was misunderstood? (see my other comments about verbose-tests)
| # Whether to always use incremental compilation when building rustc | ||
| incremental = true |
There was a problem hiding this comment.
According to Cargo documentation, the incremental default for codegen-units is 256, which makes codegen-units = 0 unnecessary/undesirable (unless you're compiling Rust on a machine with more than 256 hardware cores/threads, heh).
So my understanding is that when adding incremental = true, we also need to remove codegen-units = 0. cc @Mark-Simulacrum
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also rust-lang#795 (comment).
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also rust-lang#795 (comment).
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also #795 (comment).
Address review comments about config.toml from rustc-dev-guide PR This info was lost in rust-lang#74334. See also rust-lang/rustc-dev-guide#795 (review). r? @Mark-Simulacrum or @eddyb
No description provided.