Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt #70

Closed
wants to merge 1 commit into from
Closed

fmt #70

wants to merge 1 commit into from

Conversation

uhuntu
Copy link

@uhuntu uhuntu commented Sep 17, 2020

run cargo fmt

@aclysma
Copy link
Owner

aclysma commented Sep 17, 2020

My guess is that when you ran fmt, for whatever reason it wasn't doing it with the configuration here: https://github.com/aclysma/skulpin/blob/master/rustfmt.toml

@aclysma aclysma closed this Sep 17, 2020
@uhuntu
Copy link
Author

uhuntu commented Sep 17, 2020

The reason is fn_args_layout is outdated, I have another approach https://github.com/uhuntu/skulpin/commits/fmt2
You can review it to see if it's more reasonable ?

rust-lang/rustfmt#4149
rust-lang/rustfmt#4163

@uhuntu
Copy link
Author

uhuntu commented Sep 18, 2020

I just realized that should use stable rustfmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhuntu @aclysma