Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(threads1): make program panic if threads are not joined #1305

Merged
merged 1 commit into from
Feb 12, 2023
Merged

fix(threads1): make program panic if threads are not joined #1305

merged 1 commit into from
Feb 12, 2023

Conversation

platformer
Copy link
Contributor

@platformer platformer commented Dec 26, 2022 •
edited
Loading

Attempts to close #1298

  • program verifies that threads have been joined by checking if results vector has been filled
  • solution now involves recognizing that JoinHandle::join returns a Result, unpacking it, and adding the value to a vector

@shadows-withal shadows-withal merged commit 7be4fd8 into rust-lang:main Feb 12, 2023
@shadows-withal
Copy link
Member

@all-contributors please add @platformer for content

@allcontributors allcontributors bot mentioned this pull request Feb 12, 2023
Merged
@allcontributors
Copy link
Contributor

@shadows-withal

I've put up a pull request to add @platformer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

threads1 does not panick if not all handles are joined
2 participants
@platformer @shadows-withal