Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail better if .profile file can't be modified #292

Closed
brson opened this issue Apr 10, 2016 · 2 comments · Fixed by #1925
Closed

Fail better if .profile file can't be modified #292

brson opened this issue Apr 10, 2016 · 2 comments · Fixed by #1925

Comments

@brson
Copy link
Contributor

brson commented Apr 10, 2016

Installation will fail if ~/.profile can't be modified. This may or not be the right thing to do, but it should fail gracefully, not with the default I/O error.

@C-Saunders
Copy link
Contributor

I started looking into this because it seemed accessible, but I want to check my understanding, if possible, before continuing.

It seems like writing is initiated here and happens here, and a somewhat specific error message should result in the case of a missing permission.

Do you think the message should be more specific? Or maybe I am way off and looking in the wrong place?

@kinnison
Copy link
Contributor

I think that it may be worthwhile to, instead of using ? in the first place, instead match on the result of utils::append_file() and make a better error report or use .chain_error() again to construct a more specific error message about amending the shell profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants