Fix compiler working group links #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carols10cents the docs part of the url was introduced unintentionally. We should remove them from compiler-team repo see rust-lang/compiler-team#103 (comment) |
|
Aha, thanks! I'll wait until that gets fixed then I'll update this PR. |
spastorino
reviewed
Jul 29, 2019
teams/wg-async-await.toml
Outdated
| @@ -9,4 +9,4 @@ members = ["nikomatsakis", "cramertj"] | |||
| [website] | |||
| name = "Async-await Implementation" | |||
| description = "Implementing async-await" | |||
| repo = "https://github.com/rust-lang/compiler-team/blob/master/working-groups/async-await" | |||
| repo = "https://rust-lang.github.io/compiler-team/docs/working-groups/async-await/" | |||
There was a problem hiding this comment.
URLs now look like https://rust-lang.github.io/compiler-team/working-groups/async-await/
|
@carols10cents now yes, the docs part is out of URLs. The right changes in this PR would be what you have without the docs part. |
|
Fixed! This should be ready to merge now :) |
spastorino
approved these changes
Aug 1, 2019
|
Ready to merge, CI failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on URLO, most of the "[team] repository" buttons for the compiler working groups on this page are broken.
Looks like in rust-lang/compiler-team#103 the compiler team switched from using github as a website to using github pages as a website :)