Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify Linux riscv64 as unix #1887

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Identify Linux riscv64 as unix #1887

merged 1 commit into from
Oct 31, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Oct 31, 2023 •
edited
Loading

closes #1886

@senekor senekor requested a review from a team as a code owner October 31, 2023 19:52
@senekor senekor mentioned this pull request Oct 31, 2023
Closed
@senekor
Copy link
Contributor Author

senekor commented Oct 31, 2023

I'm unable to test this myself.

My IDE is telling me navigator.platform is deprecated, but the recommended alternative of feature detection doesn't make sense for us. We really want to know the actual platform of the user. navigator.userAgentData.platform could be an alternative in the future, but it's only supported by chromium-based browsers for now.

@Manishearth Manishearth merged commit 5738294 into rust-lang:master Oct 31, 2023
1 check passed
@senekor senekor deleted the linux-riscv64-detection branch November 18, 2023 17:43
@dtolnay dtolnay mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install Web Page Has no Appropriate Message for Debian Linux riscv64
2 participants
@senekor @Manishearth