Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy #1917

Merged
merged 35 commits into from
Jan 25, 2024
Merged

Deploy #1917

merged 35 commits into from
Jan 25, 2024

Conversation

senekor and others added 30 commits October 31, 2023 20:49
Denying all warnings for test builds results in a poor development
experience, as everying always appears as an error in the editor.
The program might still compile and run fine though.

At the same time, CI only denies rustc's warnings, not those of clippy.
So code that gets marked as an error in an editor can still pass CI.

Both of these issues are fixed by running clippy in CI explicitly.
doc(zh-CN): Fix reference to rust-analyzer in tools.ftl
    warning: accessing first element with `values.get(0)`
      --> src/i18n.rs:20:31
       |
    20 |             let email = match values.get(0) {
       |                               ^^^^^^^^^^^^^ help: try: `values.first()`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
       = note: `#[warn(clippy::get_first)]` on by default

    warning: accessing first element with `values.get(0)`
      --> src/i18n.rs:30:30
       |
    30 |             let text = match values.get(0) {
       |                              ^^^^^^^^^^^^^ help: try: `values.first()`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
Resolve Rust 1.75's new get_first clippy lint
    GET /governance/teams/leadership-council text/html:
       >> Matched: (team) GET /governance/<section>/<team> [2]
       >> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
       >> `String` is used a parameter guard in src/main.rs:224.
       >> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
       >> `String` is used a parameter guard in src/main.rs:225.
       >> Outcome: Success(200 OK)

    GET /tools/install text/html:
       >> Matched: (subject) GET /<category>/<subject> [4]
       >> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
       >> `String` is used a parameter guard in src/main.rs:260.
       >> Outcome: Success(200 OK)
Fix warnings printed by Rocket regarding String as parameter type
Regenerate en-US teams.ftl from team repo
Use Rust 1.75's async fn in trait instead of #[async_trait]
Install current stable Rust in CI
Handle launching-pad subteams.
Update Eclipse editor landing page
dtolnay and others added 5 commits January 14, 2024 10:23
@dtolnay dtolnay requested a review from a team as a code owner January 15, 2024 01:14
@Manishearth
Copy link
Member

Manishearth commented Jan 15, 2024

Staging is currently broken, unfortunately. I cannot figure out why, the logs show a succesfull build but Heroku says the build failed. It does seem like the deploy did actually succeed given the Visual Studio stuff is visible.

Not doing a deploy until someone figures out what's going on.

cc @rust-lang/infra

@dtolnay
Copy link
Member Author

dtolnay commented Jan 18, 2024

https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/www.2Erust-lang.2Eorg.20deploy.20is.20failing

Jan David Nose: Heroku lists the last three builds as failed, but has also deployed all three revisions. 🤨

Jan David Nose: The logs of the failed builds look identical to successful ones.

Jan David Nose: Since I can't find an issue on our side, I've opened a support ticket with Heroku. Will update the thread when I get a response.

@dtolnay
Copy link
Member Author

dtolnay commented Jan 25, 2024

Jan David Nose: It looks to me that the build is timing out. It's running for a veeery long time and then gets marked as failed eventually. I've purged the cache and now the builds succeed again.

https://github.com/rust-lang/www.rust-lang.org/deployments/rust-www-staging

@Manishearth Manishearth reopened this Jan 25, 2024
@Manishearth
Copy link
Member

sweet

@Manishearth Manishearth merged commit 9d411be into deploy Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants