Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render custom roles #1904

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Render custom roles #1904

merged 1 commit into from
Jan 8, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 8, 2024

rust-lang/team#1154 added support for roles other than "Team leader".

Screenshot from 2024-01-08 12-25-08

For now I've rendered only at most 1 role per member, as that's all we currently use. If members begin holding multiple roles then we'll need to render them using some internationalized notion of "comma-separated" (?) or see how sensible it would be to stack them vertically on different lines.

@dtolnay dtolnay requested a review from a team as a code owner January 8, 2024 20:40
@Manishearth Manishearth merged commit b352151 into rust-lang:master Jan 8, 2024
1 check passed
@dtolnay dtolnay deleted the roles branch January 8, 2024 21:06
This was referenced Jan 9, 2024
@m-ou-se
Copy link
Member

m-ou-se commented May 22, 2024

For now I've rendered only at most 1 role per member, as that's all we currently use.

After rust-lang/team#1458, Joel with be both "editor" and "team lead".

@dtolnay
Copy link
Member Author

dtolnay commented May 22, 2024

Paging @Manishearth. Is there a safe international way to concatenate 2 translated role strings? Or should we put "Editor and team leader" as one atomic translation?

{{#if member.is_lead}}
<div>{{fluent "governance-user-team-leader"}}</div>
{{else}}
{{#if member.roles}}
<div>{{team-text team role (lookup member.roles 0)}}</div>
{{/if}}
{{/if}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants