Bundle FFTW 3.3.8 Generated code #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termoshtt
force-pushed
the
add-fftw-codes
branch
from
931b9cb
to
1e7366e
Compare
LingMan
reviewed
Jun 21, 2020
fftw-src/.gitattributes
Outdated
| @@ -0,0 +1 @@ | |||
| fftw-*/**/* linguist-generated=true | |||
There was a problem hiding this comment.
From the documentation you linked above (emphasis mine)
- Unless the .gitattributes file already exists, create a .gitattributes file in the root of the repository.
That would suggest this file needs to be one hierarchy level up. Are you sure it will work like this?
There was a problem hiding this comment.
AFAIK, .gitignore and .gitattribute work wherever it is placed. It seems to works on GitHub
1e7366e
But it would be better to put it on the top of repository. I've moved it.
Closed
songww
pushed a commit
to songww/fftw
that referenced
this pull request
Mar 18, 2021
Bundle FFTW 3.3.8 Generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #83
TODO