Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle FFTW source code with fftw-src #83

Closed
hombit opened this issue Jun 7, 2020 · 2 comments · Fixed by #88
Closed

Bundle FFTW source code with fftw-src #83

hombit opened this issue Jun 7, 2020 · 2 comments · Fixed by #88

Comments

@hombit
Copy link
Contributor

hombit commented Jun 7, 2020

Downloading the source code of FFTW on every compilation could be inefficient or even impossible in some environments. For example, network access is blocked on docs.rs, that caused fftw-src 0.3.1 docs build fail, and can cause similar problem for dependent crates. This is why I propose to include FFTW source code into fftw-src crate.

@LingMan
Copy link
Contributor

LingMan commented Jun 7, 2020

That would also get rid of the reqwest dependency which takes a significant amount of time to compile by itself. +1

@termoshtt
Copy link
Member

I close this because #88 have realized source code bundling. Downloading issue is inherited into #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants