NAN preserving clamp_lower/upper #122

termoshtt · 2019-08-17T07:53:36Z

NAN preserving lower- and upper-clamp.

cuviper

Maybe these would be better called clamp_min and clamp_max? As far as I can see in the standard library, "lower" and "upper" are only used regarding lower/uppercase letters.

src/lib.rs

cuviper · 2019-09-14T18:23:41Z

Thanks!

bors r+

122: NAN preserving clamp_lower/upper r=cuviper a=termoshtt `NAN` preserving lower- and upper-clamp. Cc: rust-ndarray/ndarray#470 (comment) Co-authored-by: Toshiki Teramura <toshiki.teramura@gmail.com>

bors · 2019-09-14T18:34:32Z

Build succeeded

continuous-integration/travis-ci/push

62: Bump num-traits from 0.2.8 to 0.2.9 r=sopium a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.9 (2019-11-12) > > - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits > in `no_std` builds. > - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values > while preserving input `NAN`s. > - [Fixed a panic in floating point `from_str_radix` on invalid signs][126]. > - Miscellaneous documentation updates. > > **Contributors**: [@cuviper](https://github.com/cuviper), [@dingelish](https://github.com/dingelish), [@HeroicKatora](https://github.com/HeroicKatora), [@jturner314](https://github.com/jturner314), [@ocstl](https://github.com/ocstl), > [@Shnatsel](https://github.com/Shnatsel), [@termoshtt](https://github.com/termoshtt), [@waywardmonkeys](https://github.com/waywardmonkeys), [@yoanlcq](https://github.com/yoanlcq) > > [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99) > [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122) > [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126) </details> <details> <summary>Commits</summary> - [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142) - [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9 - [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes - [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137) - [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140) - [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix - [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None` - [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None` - [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments - [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99) - Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

25: Bump num-traits from 0.2.8 to 0.2.9 r=tommilligan a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.9 (2019-11-12) > > - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits > in `no_std` builds. > - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values > while preserving input `NAN`s. > - [Fixed a panic in floating point `from_str_radix` on invalid signs][126]. > - Miscellaneous documentation updates. > > **Contributors**: [@cuviper](https://github.com/cuviper), [@dingelish](https://github.com/dingelish), [@HeroicKatora](https://github.com/HeroicKatora), [@jturner314](https://github.com/jturner314), [@ocstl](https://github.com/ocstl), > [@Shnatsel](https://github.com/Shnatsel), [@termoshtt](https://github.com/termoshtt), [@waywardmonkeys](https://github.com/waywardmonkeys), [@yoanlcq](https://github.com/yoanlcq) > > [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99) > [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122) > [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126) </details> <details> <summary>Commits</summary> - [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142) - [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9 - [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes - [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137) - [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140) - [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix - [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None` - [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None` - [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments - [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99) - Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

termoshtt added 2 commits August 17, 2019 16:45

Add clamp_{lower,upper}

e8dce19

Use core::f32 instead of std::f32

f20d74f

cuviper requested changes Aug 30, 2019

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

termoshtt added 3 commits August 31, 2019 15:14

Add NaN preserving test for clamp

2fb8a6e

Replace lower/upper to min/max

e7ba9b6

Fix doc comment

973ba72

cuviper reviewed Aug 31, 2019

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

s/less/greater/g

0e7c2a4

cuviper approved these changes Sep 14, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Sep 14, 2019

Merge #122

428f89a

122: NAN preserving clamp_lower/upper r=cuviper a=termoshtt `NAN` preserving lower- and upper-clamp. Cc: rust-ndarray/ndarray#470 (comment) Co-authored-by: Toshiki Teramura <toshiki.teramura@gmail.com>

bors bot merged commit 0e7c2a4 into rust-num:master Sep 14, 2019

This was referenced Sep 21, 2019

Behavior of NAN as min/max for clamp_min/max #134

Closed

Tracking issue for clamp RFC rust-lang/rust#44095

Closed

termoshtt deleted the clamp branch November 22, 2019 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NAN preserving clamp_lower/upper #122

NAN preserving clamp_lower/upper #122

termoshtt commented Aug 17, 2019

cuviper left a comment

cuviper commented Sep 14, 2019

bors bot commented Sep 14, 2019

NAN preserving clamp_lower/upper #122

NAN preserving clamp_lower/upper #122

Conversation

termoshtt commented Aug 17, 2019

cuviper left a comment

Choose a reason for hiding this comment

cuviper commented Sep 14, 2019

bors bot commented Sep 14, 2019

Build succeeded