Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num parsing for invalid multi-byte sign chars #126

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Fix num parsing for invalid multi-byte sign chars #126

merged 1 commit into from
Aug 30, 2019

Conversation

HeroicKatora
Copy link
Contributor

Ensure that splitting the potential sign character from the remainder
respects UTF8 boundaries. This lets invalid characters fail correctly
with an error, instead of panicking.

Closes: #125

Ensure that splitting the potential sign character from the remainder
respects UTF8 boundaries. This lets invalid characters fail correctly
with an error, instead of panicking.
@cuviper
Copy link
Member

cuviper commented Aug 30, 2019

Thanks!

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2019
126: Fix num parsing for invalid multi-byte sign chars r=cuviper a=HeroicKatora

Ensure that splitting the potential sign character from the remainder
respects UTF8 boundaries. This lets invalid characters fail correctly
with an error, instead of panicking.

Closes: #125 

Co-authored-by: Andreas Molzer <andreas.molzer@gmx.de>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2019

Build succeeded

@bors bors bot merged commit cd0da1a into rust-num:master Aug 30, 2019
bors bot added a commit to blckngm/titun that referenced this pull request Nov 13, 2019
62: Bump num-traits from 0.2.8 to 0.2.9 r=sopium a=dependabot-preview[bot]

Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9.
<details>
<summary>Changelog</summary>

*Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).*

> # Release 0.2.9 (2019-11-12)
> 
> - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits
>   in `no_std` builds.
> - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values
>   while preserving input `NAN`s.
> - [Fixed a panic in floating point `from_str_radix` on invalid signs][126].
> - Miscellaneous documentation updates.
> 
> **Contributors**: [@&#8203;cuviper](https://github.com/cuviper), [@&#8203;dingelish](https://github.com/dingelish), [@&#8203;HeroicKatora](https://github.com/HeroicKatora), [@&#8203;jturner314](https://github.com/jturner314), [@&#8203;ocstl](https://github.com/ocstl),
> [@&#8203;Shnatsel](https://github.com/Shnatsel), [@&#8203;termoshtt](https://github.com/termoshtt), [@&#8203;waywardmonkeys](https://github.com/waywardmonkeys), [@&#8203;yoanlcq](https://github.com/yoanlcq)
> 
> [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99)
> [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122)
> [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126)
</details>
<details>
<summary>Commits</summary>

- [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142)
- [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9
- [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes
- [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137)
- [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140)
- [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix
- [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None`
- [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None`
- [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments
- [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99)
- Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
bors bot added a commit to blckngm/titun that referenced this pull request Nov 13, 2019
62: Bump num-traits from 0.2.8 to 0.2.9 r=sopium a=dependabot-preview[bot]

Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9.
<details>
<summary>Changelog</summary>

*Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).*

> # Release 0.2.9 (2019-11-12)
> 
> - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits
>   in `no_std` builds.
> - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values
>   while preserving input `NAN`s.
> - [Fixed a panic in floating point `from_str_radix` on invalid signs][126].
> - Miscellaneous documentation updates.
> 
> **Contributors**: [@&#8203;cuviper](https://github.com/cuviper), [@&#8203;dingelish](https://github.com/dingelish), [@&#8203;HeroicKatora](https://github.com/HeroicKatora), [@&#8203;jturner314](https://github.com/jturner314), [@&#8203;ocstl](https://github.com/ocstl),
> [@&#8203;Shnatsel](https://github.com/Shnatsel), [@&#8203;termoshtt](https://github.com/termoshtt), [@&#8203;waywardmonkeys](https://github.com/waywardmonkeys), [@&#8203;yoanlcq](https://github.com/yoanlcq)
> 
> [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99)
> [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122)
> [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126)
</details>
<details>
<summary>Commits</summary>

- [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142)
- [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9
- [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes
- [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137)
- [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140)
- [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix
- [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None`
- [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None`
- [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments
- [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99)
- Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ghost pushed a commit to tommilligan/multiplicative-persistence that referenced this pull request Nov 13, 2019
25: Bump num-traits from 0.2.8 to 0.2.9 r=tommilligan a=dependabot-preview[bot]

Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9.
<details>
<summary>Changelog</summary>

*Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).*

> # Release 0.2.9 (2019-11-12)
> 
> - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits
>   in `no_std` builds.
> - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values
>   while preserving input `NAN`s.
> - [Fixed a panic in floating point `from_str_radix` on invalid signs][126].
> - Miscellaneous documentation updates.
> 
> **Contributors**: [@&#8203;cuviper](https://github.com/cuviper), [@&#8203;dingelish](https://github.com/dingelish), [@&#8203;HeroicKatora](https://github.com/HeroicKatora), [@&#8203;jturner314](https://github.com/jturner314), [@&#8203;ocstl](https://github.com/ocstl),
> [@&#8203;Shnatsel](https://github.com/Shnatsel), [@&#8203;termoshtt](https://github.com/termoshtt), [@&#8203;waywardmonkeys](https://github.com/waywardmonkeys), [@&#8203;yoanlcq](https://github.com/yoanlcq)
> 
> [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99)
> [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122)
> [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126)
</details>
<details>
<summary>Commits</summary>

- [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142)
- [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9
- [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes
- [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137)
- [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140)
- [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix
- [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None`
- [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None`
- [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments
- [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99)
- Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_str_radix panics when the first char is encoded with multiple bytes
2 participants