Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc-serialize is deprecated, uses deprecated Rust features #424

Closed
joshhansen opened this issue Apr 4, 2023 · 2 comments
Closed

rustc-serialize is deprecated, uses deprecated Rust features #424

joshhansen opened this issue Apr 4, 2023 · 2 comments

Comments

@joshhansen
Copy link

num, by way of its subcrates' dependency rustc-serialize, is provoking this warning for me on Rust 1.68 which is now stable:

warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
note: to see what the problems were, use the option --future-incompat-report, or run cargo report future-incompatibilities --id 1

rustc-serialize is itself deprecated:

NOTE: This crate is deprecated in favor of serde. No new feature development will happen in this crate, although bug fixes proposed through PRs will still be merged. It is very highly recommended by the Rust Library Team that you use serde, not this crate.

It may be possible to get rustc-serialize to fix this; or it could be replaced with the far more widely adopted serde.

Just giving a heads up that this is on its way at some point.

FYI this is of interest to me because my Umpire project has num as a transitive dependency, by way of pitch_calc.

@cuviper
Copy link
Member

cuviper commented Apr 4, 2023

That dependency was removed almost 5 years ago when num 0.2.0 was released, but pitch_calc is using 0.1, and unfortunately rustc-serialize was enabled in the default features back then. They're not actually using that though -- in fact they could even pare down to just num-traits.

It looks like other repos in the RustAudio org are still active, so maybe you can ask them to update that.

@joshhansen
Copy link
Author

My mistake, thanks for clarifying the situation
I've filed a PR against pitch_calc, RustAudio/pitch_calc#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants