Another pass of review on UEFI protocols #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienG2
commented
Dec 11, 2018
HadrienG2
commented
Dec 11, 2018
GabrielMajeri
requested changes
Dec 12, 2018
HadrienG2
force-pushed
the
protocol_review
branch
from
ab21632
to
dc9165b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the scope creep of this PR. It started with me taking a look around the protocols code and making sure that I understand and agree with it, and then I noticed various little things like code which should be marked as unsafe, missing entry points here and there... and it grew bigger than I expected.
Let me give you a quick tour of what this does while we wait for CI to work again...