Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitflags minimum version to 1.0.4 #67

Closed
boomshroom opened this issue Apr 8, 2019 · 1 comment
Closed

Update bitflags minimum version to 1.0.4 #67

boomshroom opened this issue Apr 8, 2019 · 1 comment

Comments

@boomshroom
Copy link

boomshroom commented Apr 8, 2019

Currently, this crate requests a version compatible with 1.0.1, but uses the bitflags macro in 2018 style which wasn't supported until bitflags 1.0.4. While running cargo update or starting a new project would bypass the issue, older projects updating their dependencies will see build errors from this crate being unable to find __bitflags. Specifically, I got 41 errors between cannot find macro `__bitflags!` in this scope and various undefined structures defined within bitflags.

Essentially, x86_64 already depends on 1.0.4, but claims to be able to work with 1.0.1 when it really can't.

@phil-opp
Copy link
Member

phil-opp commented Apr 9, 2019

Good catch, thanks a lot for the report!

I pushed a fix in e0d776e and also published a new version to crates.io (0.5.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants