Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export public functions of the find module. #204

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

rbost
Copy link
Contributor

@rbost rbost commented Apr 20, 2021

Fixes #203

Copy link
Contributor

@jmcconnell26 jmcconnell26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @rbost, do you think there is any other functionality that shouldn't have been made private?

@rbost
Copy link
Contributor Author

rbost commented Apr 23, 2021

I don't think the code in geiger_syn_visitor.rs is meant to be public, and no other function from find.rs was public, so I don't think so.
But don't take my word for granted: I am not a real user of this crate.

Copy link
Contributor

@jmcconnell26 jmcconnell26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then let's keep the accessibility of everything else the same.

@jmcconnell26 jmcconnell26 merged commit 8b30ed4 into geiger-rs:master Apr 24, 2021
@anderejd
Copy link
Contributor

Should this be published as 0.4.7 or 0.5.0?

@rbost
Copy link
Contributor Author

rbost commented Apr 26, 2021

I has to be 0.4.7, for two reasons:

  1. A minor one: it just adds features, without breaking one and hence, is a minor change (at least according to Cargo's documentation.
  2. A major one: Cargo's dependency resolution algorithm would consider 0.4.6 and 0.5.0 as incompatible versions (see here, second paragraph), and not will not update the crate, making the API break essentially permanent unless dependent crates explicitly update the minimum required version.

@anderejd
Copy link
Contributor

Thanks for the information!

0.4.7 is up https://crates.io/crates/geiger/0.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking API change introduced in v0.4.6
3 participants