Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: add support for vCPU SVE feature #228

Closed
wants to merge 2 commits into from

Conversation

xuejun-xj
Copy link
Contributor

Summary of the PR

This commit add support for initialization of vCPU SVE feature on aarch64:

  1. Add ArmSve in Cap struct.
  2. Add KVM_ARM_VCPU_FINALIZE ioctl in VcpuFd struct, which is used to initialize the finalization of SVE feature for now.

This commit add support for initialization of vCPU SVE feature on
aarch64:
1. Add ArmSve in Cap struct.
2. Add KVM_ARM_VCPU_FINALIZE ioctl in VcpuFd struct, which is used to
initialize the finalization of SVE feature for now.

Signed-off-by: xuejun-xj <jiyunxue@linux.alibaba.com>
@xuejun-xj
Copy link
Contributor Author

Hi! This PR adds support for vcpu finalize ioctl. It is used to initialize SVE extention for guest vcpu. Is there anyone help to review this PR?

jiangliu
jiangliu previously approved these changes Jun 30, 2023
@jiangliu
Copy link
Member

Please also help to change the "CHANGELOG.md" file.

Signed-off-by: xuejun-xj <jiyunxue@linux.alibaba.com>
@xuejun-xj
Copy link
Contributor Author

Please also help to change the "CHANGELOG.md" file.

@jiangliu Thanks for reminder. I have added it in another commit.

@roypat
Copy link
Collaborator

roypat commented Aug 2, 2023

Hi @xuejun-xj could you have a look at resolving the conflicts so we can try getting merge before the next release? :o

xuejun-xj added a commit to xuejun-xj/kvm-ioctls that referenced this pull request Aug 2, 2023
Signed-off-by: xuejun-xj <jiyunxue@linux.alibaba.com>
@xuejun-xj
Copy link
Contributor Author

Hi @xuejun-xj could you have a look at resolving the conflicts so we can try getting merge before the next release? :o

Thanks, @roypat ! I have found something strange that I have already resolved the conflict and force-pushed to original branch. But this PR page seems nothing changed? It still shows the "Resolve conflicts" button.

image

@roypat
Copy link
Collaborator

roypat commented Aug 2, 2023

This is indeed weird - I've seen it happen a few times across different repositories the last few days, so I think GitHub is having some problems recently. Can you try closing this PR and opening a new one from the same branch? That usually fixes it for me 🤔

@xuejun-xj
Copy link
Contributor Author

This is indeed weird - I've seen it happen a few times across different repositories the last few days, so I think GitHub is having some problems recently. Can you try closing this PR and opening a new one from the same branch? That usually fixes it for me 🤔

Ok, I will open another PR for #228 .

@xuejun-xj xuejun-xj closed this Aug 2, 2023
JonathanWoollett-Light pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: xuejun-xj <jiyunxue@linux.alibaba.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants