Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy erros and warnings #23

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix clippy erros and warnings #23

merged 1 commit into from
Mar 3, 2021
+22 −27

Conversation

keiichiw
Copy link
Contributor

Make cargo clippy --all-features --all-targets pass.

@keiichiw keiichiw force-pushed the clippy branch 2 times, most recently from 3e1d5e9 to f473253 Compare February 25, 2021 02:45
@jiangliu
Copy link
Member

Thanks for help to improve code quality:)
There's a pending PR #19 , which touches/removes most of the issues solved by this PR.
So could we merge the #19 first?

@keiichiw
Copy link
Contributor Author

That sounds good to me as long as #19 will be merged soonish. I'll update (or close) this CL once #19 is merged.

@keiichiw
Fix clippy erros and warnings
8df756e 
Make `cargo clippy --all-features --all-targets` pass.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
@keiichiw keiichiw mentioned this pull request Mar 1, 2021
Closed
@keiichiw
Copy link
Contributor Author

keiichiw commented Mar 1, 2021

I just rebased my commit on #19 and made sure clippy passed. Please take a look!

@keiichiw
Copy link
Contributor Author

keiichiw commented Mar 3, 2021

Hi, can anyone give one more approval for this PR?

@jiangliu jiangliu requested review from sboeuf, slp and eryugey March 3, 2021 11:22
@jiangliu jiangliu merged commit 62fd4ec into rust-vmm:master Mar 3, 2021
vireshk referenced this pull request in vireshk/vhost Aug 17, 2022
@slp
Merge pull request #23 from jiangliu/refactor
77bc417 
Refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangliu jiangliu jiangliu approved these changes

@andreeaflorescu andreeaflorescu andreeaflorescu approved these changes

@sboeuf sboeuf Awaiting requested review from sboeuf

@slp slp Awaiting requested review from slp

@eryugey eryugey Awaiting requested review from eryugey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keiichiw @jiangliu @andreeaflorescu