-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check non-default feature code and tests in vhost-ci/clippy-x86 #25
Comments
These should be added to a custom pipeline, similar to the other rust-vmm crates that have optional features. The cargo clippy with more flags is already tracked to be added to all crates here: rust-vmm/rust-vmm-ci#21 |
Fixes rust-vmm#25. Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Fixes rust-vmm#25. Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Fixes rust-vmm#25. Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Fixes #25. Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
@jiangliu I think we need to update Buildkite as @andreeaflorescu commented at #26 (comment). |
The current
clippy-x86
builder in vhost-ci doesn't cover code for non-default features (e.g.vhost-kern
,vhost-user
, etc). So, we have some clippy errors there now, which will be fixed by #23.To improve code quality, it would be nice if we can pass more flags in clippy there like
clippy --all-targets --all-features
.The text was updated successfully, but these errors were encountered: