Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check non-default feature code and tests in vhost-ci/clippy-x86 #25

Closed
keiichiw opened this issue Mar 1, 2021 · 2 comments · Fixed by #26
Closed

Check non-default feature code and tests in vhost-ci/clippy-x86 #25

keiichiw opened this issue Mar 1, 2021 · 2 comments · Fixed by #26

Comments

@keiichiw
Copy link
Contributor

keiichiw commented Mar 1, 2021

The current clippy-x86 builder in vhost-ci doesn't cover code for non-default features (e.g. vhost-kern, vhost-user, etc). So, we have some clippy errors there now, which will be fixed by #23.
To improve code quality, it would be nice if we can pass more flags in clippy there like clippy --all-targets --all-features.

@andreeaflorescu
Copy link
Member

These should be added to a custom pipeline, similar to the other rust-vmm crates that have optional features.
Here is an example of a custom pipeline: https://github.com/rust-vmm/event-manager/blob/master/.buildkite/custom-pipeline.yml

The cargo clippy with more flags is already tracked to be added to all crates here: rust-vmm/rust-vmm-ci#21

keiichiw added a commit to keiichiw/vhost that referenced this issue Mar 3, 2021
keiichiw added a commit to keiichiw/vhost that referenced this issue Mar 3, 2021
Fixes rust-vmm#25.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
keiichiw added a commit to keiichiw/vhost that referenced this issue Mar 3, 2021
Fixes rust-vmm#25.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
keiichiw added a commit to keiichiw/vhost that referenced this issue May 18, 2021
Fixes rust-vmm#25.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
jiangliu pushed a commit that referenced this issue May 18, 2021
Fixes #25.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
@keiichiw
Copy link
Contributor Author

@jiangliu I think we need to update Buildkite as @andreeaflorescu commented at #26 (comment).
Can I ask you to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants