Make Mac borderless windows resizable and draggable. #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You mean: servo/servo#9856 and servo/servo#9878 |
pcwalton
force-pushed
the
mac-resize-drag-borderless-tomaka
branch
from
e532d1f
to
c4c5123
Compare
Despite the fact that the style mask contains `NSTitledWindowMask`, the title doesn't show up for two reasons: (a) we draw over it; (b) we make it invisible with a call to `-[NSWindow setTitleVisibility:]`. Addresses servo/servo#9856 and servo/servo#9878. Partially addresses servo/servo#9812.
pcwalton
force-pushed
the
mac-resize-drag-borderless-tomaka
branch
from
c4c5123
to
7249529
Compare
|
r+ |
|
Depends on #741. |
Landed. |
| NSBorderlessWindowMask as NSUInteger | ||
| NSBorderlessWindowMask as NSUInteger | | ||
| NSResizableWindowMask as NSUInteger | | ||
| NSTitledWindowMask as NSUInteger |
There was a problem hiding this comment.
Alternatively, pull out NSResizableWindowMask and NSTitledWindowMask since they're available in every branch of the conditional now.
|
@paulrouget @tomaka Is there something I should do to move this along? |
|
I was waiting for Travis. |
paulrouget
added a commit
that referenced
this pull request
Mar 16, 2016
Make Mac borderless windows resizable and draggable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that the style mask contains
NSTitledWindowMask, thetitle doesn't show up for two reasons: (a) we draw over it; (b) we make
it invisible with a call to
-[NSWindow setTitleVisibility:].Addresses servo/servo#9877 and servo/servo#9878.
r? @paulrouget