This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Make Mac borderless windows resizable and draggable. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwalton
force-pushed
the
mac-resize-drag-borderless-servo
branch
from
cdb6f14
to
defcfc9
Compare
Despite the fact that the style mask contains `NSTitledWindowMask`, the title doesn't show up for two reasons: (a) we draw over it; (b) we make it invisible with a call to `-[NSWindow setTitleVisibility:]`. Addresses servo/servo#9856 and servo/servo#9878. Partially addresses servo/servo#9812.
|
This has landed upstream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that the style mask contains
NSTitledWindowMask, thetitle doesn't show up for two reasons: (a) we draw over it; (b) we make
it invisible with a call to
-[NSWindow setTitleVisibility:].Addresses servo/servo#9877 and servo/servo#9878.
r? @metajack
cc @paulrouget
Submitted upstream at rust-windowing#740.
This change is