Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Basis3 or Matrix3 identity? #518

Open
thorlucas opened this issue Oct 14, 2020 · 3 comments
Open

No Basis3 or Matrix3 identity? #518

thorlucas opened this issue Oct 14, 2020 · 3 comments
Labels
question

Comments

@thorlucas
Copy link

Why is there no way to just do Basis3::<f32>::identity()?
@kvark
Copy link
Collaborator

kvark commented Oct 15, 2020

You can do Basis3::one() or Basis3::from_quaternion(Quaternion::one())

@kvark kvark added the question label Oct 15, 2020
@thorlucas
Copy link
Author

Thanks! I find that to be a bit of an unintuitive way to name it, no?

@kvark
Copy link
Collaborator

kvark commented Oct 15, 2020

Yes, well, it's just that cgmath has a One trait that it tries to use everywhere..
It could have an alias method named identity in the basis3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @thorlucas