Temporary dupe fix.

[harrydevane]

This is causing dupes when entering stacked spawners/stacked potions into enderchests. You can turn 3 spawners into 1000.

[rutgerkok]

It looks like inventory.setItem(slot, null) doesn't clear the slot anymore. It also looks like that dragging items into disabled slots now works. This is interesting, as when I originally wrote that code, it worked fine.

Many thanks for pointing this out. I'd rather not disable shift-clicking, so I made another fix. Is the fix I made enough to prevent duplication for now, or do I need to pull this?

[rutgerkok]

I believe this is fixed in 2.2.0.

[harrydevane]

Its back

[harrydevane]

Same issue.

[rutgerkok]

Still with shift-click? I can't seem to reproduce it.

[harrydevane]

It only worked in some slots with our rank 'kingpin' which had the permission betterenderchest.slots.upgrade7 which equals slotsUpgrade7: 48 (48 slots) and it does not work with every slot. And yes with shift-clicking

[harrydevane]

This still happens, fixed with the code i changed in this PR.

[rutgerkok]

The code disables shift-clicking altogether. It is not something I want to add. (As an option it would be fine.) There must be a bug somewhere in the handleShiftClick method; the item count is probably miscalculated.

I haven't been able to reproduce this..

[harrydevane]

Did you try reproducing with "It only worked in some slots with our rank 'kingpin' which had the permission betterenderchest.slots.upgrade7 which equals slotsUpgrade7: 48 (48 slots) and it does not work with every slot. And yes with shift-clicking" while using silkspawners and spawners-unstackable: true in its config?

[rutgerkok]

I installed SilkSpawner and made spawners unstackable. The behavior was more buggy, there are quite a few visual duplication glitches, but no actual duplication bugs. Tested quite a few slots in a chest with 48 slots. Tested situations where the spawners would fit, tested situations where the spawners wouldn't fit. Whatever I do, there seems to be no way to end up with more spawners. Only in creative I'm able to duplicate items, but that's because the server believes everything the client says.

Do you have a more detailed explanation? A screenshot of the inventory, which item to shift-click, etc?

Edit: running SilkSpawners 3.5 and BetterEnderChest 2.2.4.