Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant search (filter list) #4

Open
paoloantinori opened this issue May 12, 2015 · 5 comments
Open

Instant search (filter list) #4

paoloantinori opened this issue May 12, 2015 · 5 comments

Comments

@paoloantinori
Copy link

Hi, this addon is very handy. It would be even better if I could press a key like / and type a keyword and have the options filtered based on that.

@ruyadorno ruyadorno changed the title [enhancement] instant search Instant search May 12, 2015
@ruyadorno
Copy link
Owner

Yeah, it's a great idea, @zeachco might also be interested in following since he proposed the same thing 😄

The trickiest part is how to plug the filtering functionality along with Inquirer.js (the node dependency that provides the interactive menu).

I'd be happy to review a contribution for that and might give it a try in the future if nobody else comes up with a PR first.

Thanks!

@zeachco
Copy link
Collaborator

zeachco commented May 13, 2015

Looked at it and I think inquirer is already working on an auto-complete feature (SBoudrias/Inquirer.js#225) I also feel it would be a ore logical place to have it

@ruyadorno ruyadorno changed the title Instant search Instant search (filter list) May 14, 2015
@paoloantinori
Copy link
Author

slowly getting there:

https://asciinema.org/a/2abz5r1f4sfsahhbl6161nc3f

@ruyadorno
Copy link
Owner

👍 looking good!

@mokkabonna
Copy link

FYI I have a open PR for this now, feedback is wanted. SBoudrias/Inquirer.js#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants