-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading bl@6.0.10 to bl@6.0.12 creates issues #140
Comments
@kyle-johnson are you able to help out with this one? I don't understand it at all and my instinct is to downgrade the types package to a devdep, but reviewing #133 suggests that's not appropriate. perhaps it should just be upped to match the readable-stream semver since it's at The two conflicting packages are doing fairly similar things though: https://github.com/mqttjs/MQTT.js/blob/8d5936eda1ca90694f6ae6e95567d4065a8efda3/package.json#L111C13-L122 their readable-stream types allow lower than the actual readable-stream package. 🤷 maybe it's just time to bump both of them. |
FYI: the generated (and attached) |
FYI: It was an upstream issue with the type definitions we all are using. @JKRhb from the thingweb team detected and fixed the problem, see DefinitelyTyped/DefinitelyTyped#69974 for more details. Hence, I am closing the issue...
|
We are running into an issue when upgrading from
v6.0.10
tov6.0.12
.Do you have an idea what might cause this problem?
We noticed that with
v6.0.12
it pulls in a new dependency@types/readable-stream@4.0.0
which causes the problems in our case.Any helps or pointer is appreciated. Thanks!
see also eclipse-thingweb/node-wot#1292
The text was updated successfully, but these errors were encountered: